Re: [PULL 26/42] target/arm: Use tcg_gen_qemu_{ld, st}_i128 in gen_sve_{ld, st}r

[Jonathan Cameron]

On Mon, 12 Jun 2023 19:40:29 +0100
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:

> On 12/06/2023 16:20, Jonathan Cameron via wrote:
> 
> > On Tue,  6 Jun 2023 10:47:58 +0100
> > Peter Maydell <peter.maydell@linaro.org> wrote:
> >   
> >> From: Richard Henderson <richard.henderson@linaro.org>
> >>
> >> Round len_align to 16 instead of 8, handling an odd 8-byte as part
> >> of the tail.  Use MO_ATOM_NONE to indicate that all of these memory
> >> ops have only byte atomicity.
> >>
> >> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> >> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> >> Message-id: 20230530191438.411344-8-richard.henderson@linaro.org
> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>  
> > 
> > Early in debugging but a git bisect pointed at this patch causing:
> > 
> > ERROR:../../tcg/tcg.c:4317:temp_load: code should not be reached
> > Bail out! ERROR:../../tcg/tcg.c:4317:temp_load: code should not be reached
> > Aborted
> > 
> > Just after Run /sbin/init arm64 / virt running on an x86 host.
> > cpu max.
> > 
> > Just reverting this patch results in length check failures.
> > I reverted as follows
> > 
> > 
> > revert: Revert "target/arm: Use tcg_gen_qemu_{ld, st}_i128 in gen_sve_{ld, 
> > st}r"
> > revert: Revert "target/arm: Sink gen_mte_check1 into load/store_exclusive"
> > revert: Revert "target/arm: Load/store integer pair with one tcg operation"
> > revert: Revert "target/arm: Hoist finalize_memop out of do_gpr_{ld, st}"
> > revert: Revert "target/arm: Hoist finalize_memop out of do_fp_{ld, st}"
> > revert: Revert "target/arm: Pass memop to gen_mte_check1*"
> > revert: Revert "target/arm: Pass single_memop to gen_mte_checkN"
> > revert: Revert "target/arm: Check alignment in helper_mte_check"
> > revert: Revert "target/arm: Add SCTLR.nAA to TBFLAG_A64"
> > revert: Revert "target/arm: Relax ordered/atomic alignment checks for LSE2"
> > revert: Revert "target/arm: Move mte check for store-exclusive"
> > 
> > and all is good - obviously that's probably massive overkill.
> > 
> > Jonathan  
> 
> Could this possibly be the same as 
> https://gitlab.com/qemu-project/qemu/-/issues/1704?

Seems likely.  I'll watch that issue for a resolution.

Thanks!

Jonathan

> 
> 
> ATB,
> 
> Mark.
>