[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 06/10] target/i386: Intel only supports SYSCALL in long mode
From: |
Paolo Bonzini |
Subject: |
[PATCH v2 06/10] target/i386: Intel only supports SYSCALL in long mode |
Date: |
Tue, 20 Jun 2023 17:16:30 +0200 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/cpu.c | 4 ++++
target/i386/tcg/translate.c | 5 ++++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 695e01582bf..978d24b5ec7 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6238,6 +6238,10 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index,
uint32_t count,
*ecx |= 1 << 1; /* CmpLegacy bit */
}
}
+ if (tcg_enabled() && env->cpuid_vendor1 == CPUID_VENDOR_INTEL_1 &&
+ !(env->hflags & HF_LMA_MASK)) {
+ *edx &= ~CPUID_EXT2_SYSCALL;
+ }
break;
case 0x80000002:
case 0x80000003:
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 89df7bb528a..9aec7ec8288 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -5684,7 +5684,10 @@ static bool disas_insn(DisasContext *s, CPUState *cpu)
break;
#ifdef TARGET_X86_64
case 0x105: /* syscall */
- /* XXX: is it usable in real mode ? */
+ /* For Intel SYSCALL is only valid in long mode */
+ if (!LMA(s) && env->cpuid_vendor1 == CPUID_VENDOR_INTEL_1) {
+ goto illegal_op;
+ }
gen_update_cc_op(s);
gen_update_eip_cur(s);
gen_helper_syscall(cpu_env, cur_insn_len_i32(s));
--
2.40.1
- [PATCH v2 05/10] target/i386: TCG supports WBNOINVD, (continued)
- [PATCH v2 05/10] target/i386: TCG supports WBNOINVD, Paolo Bonzini, 2023/06/20
- [PATCH v2 02/10] target/i386: TCG supports 3DNow! prefetch(w), Paolo Bonzini, 2023/06/20
- [PATCH v2 01/10] target/i386: fix INVD vmexit, Paolo Bonzini, 2023/06/20
- [PATCH v2 07/10] target/i386: sysret and sysexit are privileged, Paolo Bonzini, 2023/06/20
- [PATCH v2 08/10] target/i386: implement 32-bit SYSCALL for linux-user, Paolo Bonzini, 2023/06/20
- [PATCH v2 09/10] target/i386: implement 32-bit SYSENTER for linux-user, Paolo Bonzini, 2023/06/20
- [PATCH v2 06/10] target/i386: Intel only supports SYSCALL in long mode,
Paolo Bonzini <=
- [PATCH v2 10/10] target/i386: implement RDPID in TCG, Paolo Bonzini, 2023/06/20