Re: [PATCH v2 08/10] target/i386: implement 32-bit SYSCALL for linux-user

[Richard Henderson]

On 6/20/23 17:16, Paolo Bonzini wrote:
> @@ -211,6 +211,9 @@ void cpu_loop(CPUX86State *env)
>  
>          switch(trapnr) {
>          case 0x80:
> +#ifdef TARGET_ABI32
> +        case EXCP_SYSCALL:
> +#endif
>              /* linux syscall from int $0x80 */

ABI32 includes x32.
I think you want TARGET_I386.

> +#if defined CONFIG_SOFTMMU || defined CONFIG_LINUX_USER
> +#define TCG_EXT2_NOBSD_FEATURES CPUID_EXT2_SYSCALL
> +#else
> +#define TCG_EXT2_NOBSD_FEATURES 0
> +#endif

Missing TARGET_I386 test per above.
Better named TCG_EXT2_USERONLY_FEATURES.

Warner, if I'm reading freebsd-src correctly, sys/x86 (aka 32-bit) does not use 
sysenter/sysret?  I only see that under sys/amd64 (where fast_syscall32 is a cya nop).


r~