Re: [PATCH 5/9] accel: Move CPUTLB to CPUState and assert offset

[Richard Henderson]

On 6/30/23 14:25, Anton Johansson wrote:
> @@ -448,6 +448,13 @@ struct CPUState {
>   
>       /* track IOMMUs whose translations we've cached in the TCG TLB */
>       GArray *iommu_notifiers;
> +
> +    /*
> +     * The following fields needs to be within CPU_MAX_NEGATIVE_ENV_OFFSET of
> +     * CPUArchState.  As CPUArchState is assumed to follow CPUState in the
> +     * ArchCPU struct these are placed last.  This is checked statically.
> +     */
> +    CPUTLB tlb;
>   };

This is what we had before CPUNegativeOffsetState, comment and all, and over the course of 
time the comment was ignored and the CPUTLB crept toward the middle of the structure.

I really don't see how this merge helps.  There's nothing target-specific about 
CPUTLBDescFast or CPUNegativeOffsetState, and keeping them separate enforces their importance.


r~