[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/8] qemu-nbd: invent nbd_client_release_pipe() helper
From: |
Denis V. Lunev |
Subject: |
[PATCH 5/8] qemu-nbd: invent nbd_client_release_pipe() helper |
Date: |
Wed, 6 Sep 2023 11:32:07 +0200 |
Move the code from main() and nbd_client_thread() into the specific
helper. This code is going to be grown.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Eric Blake <eblake@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
qemu-nbd.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index d0f8d8bad2..9f28e3ebda 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -259,6 +259,16 @@ struct NbdClientOpts {
bool verbose;
};
+static void nbd_client_release_pipe(void)
+{
+ /* Close stderr so that the qemu-nbd process exits. */
+ if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
+ error_report("Could not release pipe to parent: %s",
+ strerror(errno));
+ exit(EXIT_FAILURE);
+ }
+}
+
#if HAVE_NBD_DEVICE
static void *show_parts(void *arg)
{
@@ -322,12 +332,7 @@ static void *nbd_client_thread(void *arg)
fprintf(stderr, "NBD device %s is now connected to %s\n",
opts->device, opts->srcpath);
} else {
- /* Close stderr so that the qemu-nbd process exits. */
- if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
- error_report("Could not release pipe to parent: %s",
- strerror(errno));
- exit(EXIT_FAILURE);
- }
+ nbd_client_release_pipe();
}
if (nbd_client(fd) < 0) {
@@ -1176,11 +1181,7 @@ int main(int argc, char **argv)
}
if (opts.fork_process) {
- if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
- error_report("Could not release pipe to parent: %s",
- strerror(errno));
- exit(EXIT_FAILURE);
- }
+ nbd_client_release_pipe();
}
state = RUNNING;
--
2.34.1
- [PATCH v3 0/8] qemu-nbd: Restore "qemu-nbd -v --fork" output, Denis V. Lunev, 2023/09/06
- [PATCH 2/8] qemu-nbd: define struct NbdClientOpts when HAVE_NBD_DEVICE is not defined, Denis V. Lunev, 2023/09/06
- [PATCH 1/8] qemu-nbd: improve error message for dup2 error, Denis V. Lunev, 2023/09/06
- [PATCH 4/8] qemu-nbd: put saddr into into struct NbdClientOpts, Denis V. Lunev, 2023/09/06
- [PATCH 5/8] qemu-nbd: invent nbd_client_release_pipe() helper,
Denis V. Lunev <=
- [PATCH 8/8] qemu-nbd: fix formatting in main(), Denis V. Lunev, 2023/09/06
- [PATCH 6/8] qemu-nbd: Restore "qemu-nbd -v --fork" output, Denis V. Lunev, 2023/09/06
- [PATCH 7/8] qemu-nbd: document -v behavior in respect to --fork in man, Denis V. Lunev, 2023/09/06
- [PATCH 3/8] qemu-nbd: move srcpath into struct NbdClientOpts, Denis V. Lunev, 2023/09/06