[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/8] qemu-nbd: improve error message for dup2 error
From: |
Denis V. Lunev |
Subject: |
[PATCH 1/8] qemu-nbd: improve error message for dup2 error |
Date: |
Wed, 6 Sep 2023 11:32:03 +0200 |
This error is happened when we are not able to close the pipe to the
parent (to trace errors in the child process) and assign stderr to
/dev/null as required by the daemonizing convention.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Suggested-by: Eric Blake <eblake@redhat.com>
CC: Eric Blake <eblake@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
qemu-nbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index aaccaa3318..4575e4291e 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -324,7 +324,7 @@ static void *nbd_client_thread(void *arg)
} else {
/* Close stderr so that the qemu-nbd process exits. */
if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
- error_report("Could not set stderr to /dev/null: %s",
+ error_report("Could not release pipe to parent: %s",
strerror(errno));
exit(EXIT_FAILURE);
}
@@ -1181,7 +1181,7 @@ int main(int argc, char **argv)
if (fork_process) {
if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
- error_report("Could not set stderr to /dev/null: %s",
+ error_report("Could not release pipe to parent: %s",
strerror(errno));
exit(EXIT_FAILURE);
}
--
2.34.1
- [PATCH v3 0/8] qemu-nbd: Restore "qemu-nbd -v --fork" output, Denis V. Lunev, 2023/09/06
- [PATCH 2/8] qemu-nbd: define struct NbdClientOpts when HAVE_NBD_DEVICE is not defined, Denis V. Lunev, 2023/09/06
- [PATCH 1/8] qemu-nbd: improve error message for dup2 error,
Denis V. Lunev <=
- [PATCH 4/8] qemu-nbd: put saddr into into struct NbdClientOpts, Denis V. Lunev, 2023/09/06
- [PATCH 5/8] qemu-nbd: invent nbd_client_release_pipe() helper, Denis V. Lunev, 2023/09/06
- [PATCH 8/8] qemu-nbd: fix formatting in main(), Denis V. Lunev, 2023/09/06
- [PATCH 6/8] qemu-nbd: Restore "qemu-nbd -v --fork" output, Denis V. Lunev, 2023/09/06
- [PATCH 7/8] qemu-nbd: document -v behavior in respect to --fork in man, Denis V. Lunev, 2023/09/06