[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/8] qemu-nbd: Restore "qemu-nbd -v --fork" output
From: |
Eric Blake |
Subject: |
Re: [PATCH 6/8] qemu-nbd: Restore "qemu-nbd -v --fork" output |
Date: |
Thu, 7 Sep 2023 16:59:23 -0500 |
User-agent: |
NeoMutt/20230517 |
On Wed, Sep 06, 2023 at 11:32:08AM +0200, Denis V. Lunev wrote:
> Closing stderr earlier is good for daemonized qemu-nbd under ssh
> earlier, but breaks the case where -v is being used to track what is
> happening in the server, as in iotest 233.
>
> When we know we are verbose, we should preserve original stderr and
> restore it once the setup stage is done. This commit restores the
> original behavior with -v option. In this case original output
> inside the test is kept intact.
>
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> CC: Hanna Reitz <hreitz@redhat.com>
> CC: Mike Maslenkin <mike.maslenkin@gmail.com>
> Fixes: 5c56dd27a2 ("qemu-nbd: fix regression with qemu-nbd --fork run over
> ssh")
> ---
> qemu-nbd.c | 24 ++++++++++++++++++++----
> 1 file changed, 20 insertions(+), 4 deletions(-)
Tested-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- Re: [PATCH 2/8] qemu-nbd: define struct NbdClientOpts when HAVE_NBD_DEVICE is not defined, (continued)
- [PATCH 1/8] qemu-nbd: improve error message for dup2 error, Denis V. Lunev, 2023/09/06
- [PATCH 4/8] qemu-nbd: put saddr into into struct NbdClientOpts, Denis V. Lunev, 2023/09/06
- [PATCH 5/8] qemu-nbd: invent nbd_client_release_pipe() helper, Denis V. Lunev, 2023/09/06
- [PATCH 8/8] qemu-nbd: fix formatting in main(), Denis V. Lunev, 2023/09/06
- [PATCH 6/8] qemu-nbd: Restore "qemu-nbd -v --fork" output, Denis V. Lunev, 2023/09/06
- Re: [PATCH 6/8] qemu-nbd: Restore "qemu-nbd -v --fork" output,
Eric Blake <=
- [PATCH 7/8] qemu-nbd: document -v behavior in respect to --fork in man, Denis V. Lunev, 2023/09/06
- [PATCH 3/8] qemu-nbd: move srcpath into struct NbdClientOpts, Denis V. Lunev, 2023/09/06