Re: [PATCH 22/33] target/ppc: moved stxvx and lxvx from legacy to decodtree

[Richard Henderson]

On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote:
> @@ -2075,7 +1969,7 @@ static void gen_xvxsigdp(DisasContext *ctx)
>       tcg_temp_free_i64(xbl);
>   }
>   
> -static bool do_lstxv(DisasContext *ctx, int ra, int displ,
> +static bool do_lstxv(DisasContext *ctx, int ra, TCGv displ,
>                        int rt, bool store)
>   {
>       TCGv ea;
> @@ -2089,7 +1983,7 @@ static bool do_lstxv(DisasContext *ctx, int ra, int displ,
>       mop = DEF_MEMOP(MO_Q);
>   
>       gen_set_access_type(ctx, ACCESS_INT);
> -    do_ea_calc(ctx, ra, tcg_const_tl(displ), ea);
> +    do_ea_calc(ctx, ra, displ, ea);
>   
>       if (ctx->le_mode) {
>           gen_addr_add(ctx, ea, ea, 8);
> @@ -2127,11 +2021,26 @@ static bool do_lstxv_D(DisasContext *ctx, arg_D *a, 
> bool store)
>           REQUIRE_VECTOR(ctx);
>       }
>   
> -    return do_lstxv(ctx, a->ra, a->si, a->rt, store);
> +    return do_lstxv(ctx, a->ra, tcg_constant_tl(a->si), a->rt, store);

Ah, if these 3 lines had been in the previous patch, I wouldn't have been asking silly 
questions.  :-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~