Re: [PATCH 17/33] target/ppc: Implement Vector Insert from VSR using GPR index insns

[Richard Henderson]

On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote:
> -        qemu_log_mask(LOG_GUEST_ERROR, "Invalid index for VINS" #SUFFIX "%cX"  
> \
> -                      " at 0x" TARGET_FMT_lx ", RA = " TARGET_FMT_ld " > 
> %d\n",\
> -                      c, env->nip, idx, maxidx);                               
> \
> +        qemu_log_mask(LOG_GUEST_ERROR, "Invalid index for VINS" #SUFFIX "%cX/" 
> \
> +                      "VINS" #SUFFIX "V%cX at 0x" TARGET_FMT_lx ", RA = "      
> \
> +                      TARGET_FMT_ld " > %d\n", c, c, env->nip, idx, maxidx);   
> \

Maybe just begin with "vector insert element", since this eventually gets used for 
vinsert* as well.  At which point the FOO/BAR/BAZ format becomes excessive.


r~