Re: [PATCH 21/33] target/ppc: moved stxv and lxv from legacy to decodtree

[Richard Henderson]

On 10/23/21 1:34 PM, Richard Henderson wrote:
> On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote:
> > +static bool do_lstxv(DisasContext *ctx, int ra, int displ,
> > +                     int rt, bool store)
>
> You need an int64_t displ before you add PLXV et al.  What happened to passing in arg_D as 
> for the other integer instructions?
>
> > +    do_ea_calc(ctx, ra, tcg_const_tl(displ), ea);
> > +
> > +    if (ctx->le_mode) {
> > +        gen_addr_add(ctx, ea, ea, 8);
> > +        offset = -8;
> > +    } else {
> > +        offset = 8;
> > +    }
>
> Adjust displ for le_mode, then you don't have to do the addition twice.

Nevermind, next patch fixes this one.
Fold the 3 lines back for a

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~