[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 06/11] rust/block: Add I/O buffer traits
From: |
Kevin Wolf |
Subject: |
[PATCH v2 06/11] rust/block: Add I/O buffer traits |
Date: |
Tue, 18 Feb 2025 19:20:14 +0100 |
Types that implement IoBuffer can be used with safe I/O functions.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
rust/block/src/iobuffer.rs | 94 ++++++++++++++++++++++++++++++++++++++
rust/block/src/lib.rs | 2 +
2 files changed, 96 insertions(+)
create mode 100644 rust/block/src/iobuffer.rs
diff --git a/rust/block/src/iobuffer.rs b/rust/block/src/iobuffer.rs
new file mode 100644
index 0000000000..d61370c961
--- /dev/null
+++ b/rust/block/src/iobuffer.rs
@@ -0,0 +1,94 @@
+// Copyright Red Hat Inc.
+// Author(s): Kevin Wolf <kwolf@redhat.com>
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+use std::mem::MaybeUninit;
+
+/// Types that implement IoBuffer can be used with safe I/O functions.
+///
+/// # Safety
+///
+/// `buffer_ptr()` and `buffer_mut_ptr()` must return pointers to the address
of the same I/O
+/// buffer with the size returned by `buffer_len()` which remain valid for the
lifetime of the
+/// object. It must be safe for the I/O buffer to contain any byte patterns.
+pub unsafe trait IoBuffer {
+ /// Returns a const pointer to be used as a raw I/O buffer
+ fn buffer_ptr(&self) -> *const u8;
+
+ /// Returns a mutable pointer to be used as a raw I/O buffer
+ fn buffer_mut_ptr(&mut self) -> *mut u8;
+
+ /// Returns the length in bytes for the raw I/O buffer returned by
[`buffer_ptr`] and
+ /// [`buffer_mut_ptr`]
+ ///
+ /// [`buffer_ptr`]: IoBuffer::buffer_ptr
+ /// [`buffer_mut_ptr`]: IoBuffer::buffer_mut_ptr
+ fn buffer_len(&self) -> usize;
+}
+
+/// Implementing `SizedIoBuffer` provides an implementation for [`IoBuffer`]
without having to
+/// implement any functions manually.
+///
+/// # Safety
+///
+/// Types implementing `SizedIoBuffer` guarantee that the whole object can be
accessed as an I/O
+/// buffer that is safe to contain any byte patterns.
+pub unsafe trait SizedIoBuffer: Sized {
+ /// Safely converts a byte slice into a shared reference to the type
implementing
+ /// `SizedIoBuffer`
+ fn from_byte_slice(buf: &[u8]) -> Option<&Self> {
+ if buf.len() < std::mem::size_of::<Self>() {
+ return None;
+ }
+
+ let ptr = buf.as_ptr() as *const Self;
+
+ // TODO Use ptr.is_aligned() when MSRV is updated to at least 1.79.0
+ if (ptr as usize) % std::mem::align_of::<Self>() != 0 {
+ return None;
+ }
+
+ // SAFETY: This function checked that the byte slice is large enough
and aligned.
+ // Implementing SizedIoBuffer promises that any byte pattern is valid
for the type.
+ Some(unsafe { &*ptr })
+ }
+}
+
+unsafe impl<T: SizedIoBuffer> IoBuffer for T {
+ fn buffer_ptr(&self) -> *const u8 {
+ self as *const Self as *const u8
+ }
+
+ fn buffer_mut_ptr(&mut self) -> *mut u8 {
+ self as *mut Self as *mut u8
+ }
+
+ fn buffer_len(&self) -> usize {
+ std::mem::size_of::<Self>()
+ }
+}
+
+unsafe impl<T: SizedIoBuffer> IoBuffer for [T] {
+ fn buffer_ptr(&self) -> *const u8 {
+ self.as_ptr() as *const u8
+ }
+
+ fn buffer_mut_ptr(&mut self) -> *mut u8 {
+ self.as_mut_ptr() as *mut u8
+ }
+
+ fn buffer_len(&self) -> usize {
+ std::mem::size_of_val(self)
+ }
+}
+
+unsafe impl<T: SizedIoBuffer> SizedIoBuffer for MaybeUninit<T> {}
+
+unsafe impl SizedIoBuffer for u8 {}
+unsafe impl SizedIoBuffer for u16 {}
+unsafe impl SizedIoBuffer for u32 {}
+unsafe impl SizedIoBuffer for u64 {}
+unsafe impl SizedIoBuffer for i8 {}
+unsafe impl SizedIoBuffer for i16 {}
+unsafe impl SizedIoBuffer for i32 {}
+unsafe impl SizedIoBuffer for i64 {}
diff --git a/rust/block/src/lib.rs b/rust/block/src/lib.rs
index 8b13789179..1c03549821 100644
--- a/rust/block/src/lib.rs
+++ b/rust/block/src/lib.rs
@@ -1 +1,3 @@
+mod iobuffer;
+pub use iobuffer::{IoBuffer, SizedIoBuffer};
--
2.48.1
- [PATCH v2 00/11] rust/block: Add minimal block driver bindings, Kevin Wolf, 2025/02/18
- [PATCH v2 02/11] meson: Add rust_block_ss and link tools with it, Kevin Wolf, 2025/02/18
- [PATCH v2 01/11] rust: Build separate qemu_api_tools and qemu_api_system, Kevin Wolf, 2025/02/18
- [PATCH v2 05/11] rust/block: Add empty crate, Kevin Wolf, 2025/02/18
- [PATCH v2 04/11] rust/qemu-api: Add wrappers to run futures in QEMU, Kevin Wolf, 2025/02/18
- [PATCH v2 06/11] rust/block: Add I/O buffer traits,
Kevin Wolf <=
- [PATCH v2 08/11] rust/block: Add driver module, Kevin Wolf, 2025/02/18
- [PATCH v2 09/11] rust/block: Add read support for block drivers, Kevin Wolf, 2025/02/18
- [PATCH v2 03/11] rust: Add some block layer bindings, Kevin Wolf, 2025/02/18
- [PATCH v2 07/11] block: Add bdrv_open_blockdev_ref_file(), Kevin Wolf, 2025/02/18
- [PATCH v2 11/11] rust/block: Add format probing, Kevin Wolf, 2025/02/18
- [PATCH v2 10/11] bochs-rs: Add bochs block driver reimplementation in Rust, Kevin Wolf, 2025/02/18