Re: [PATCH v2 05/11] rust/block: Add empty crate

[Zhao Liu]

> diff --git a/rust/block/Cargo.toml b/rust/block/Cargo.toml
> new file mode 100644
> index 0000000000..fbc2f2d6ef
> --- /dev/null
> +++ b/rust/block/Cargo.toml
> @@ -0,0 +1,16 @@
> +[package]
> +name = "block"
> +version = "0.1.0"
> +edition = "2021"
> +authors = ["Kevin Wolf <kwolf@redhat.com>"]
> +license = "GPL-2.0-or-later"
> +readme = "README.md"
> +description = "Block backends for QEMU"
> +repository = "https://gitlab.com/qemu-project/qemu/";
> +publish = false
> +keywords = []
> +categories = []

Per the commit f26137893b98 ("rust: remove unnecessary Cargo.toml
metadata"), readme & repository are not necessary. :-)

And rust-version is needed (since the commit 669fab6a1f3e).

> +[dependencies]
> +qemu_api = { path = "../qemu-api" }
> +libc = "0.2.162"

I think it's necessary add the lints section to apply workspace's lint
configurations:

[lints]
workspace = true

> diff --git a/rust/block/README.md b/rust/block/README.md
> new file mode 100644
> index 0000000000..debcc9d815
> --- /dev/null
> +++ b/rust/block/README.md
> @@ -0,0 +1,3 @@
> +# QEMU block backends
> +
> +This library implements block drivers for QEMU.

And doc can be updated in docs/devel/rust.rst, like Paolo's patch:

20250218080455.426383-1-pbonzini@redhat.com/">https://lore.kernel.org/qemu-devel/20250218080455.426383-1-pbonzini@redhat.com/

> diff --git a/rust/block/meson.build b/rust/block/meson.build
> new file mode 100644
> index 0000000000..ca93afd939
> --- /dev/null
> +++ b/rust/block/meson.build
> @@ -0,0 +1,20 @@
> +_block_rs = static_library(
> +  'block',
> +  files('src/lib.rs'),
> +  override_options: ['rust_std=2021', 'build.rust_std=2021'],
> +  rust_abi: 'rust',
> +  dependencies: [
> +    qemu_api_tools,
> +    qemu_api_macros,

I'm unsure without testing, the dependencies here looks different with
the Cargo.toml?

Regards,
Zhao