[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [STUMP] [PATCH] Add battery2.lisp - works with multiple batteries, u
From: |
John Li |
Subject: |
Re: [STUMP] [PATCH] Add battery2.lisp - works with multiple batteries, uses sysfs. |
Date: |
Mon, 21 Jul 2008 11:42:31 -0400 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Jul 21, 2008 at 03:03:35AM +0200, Julian Stecklina wrote:
>
> I renamed your hacked read-line for SBCL to read-line-from-sysfs and
> moved it to wrappers.lisp, since at least the cpu contrib could use the
> same overhaul (and workaround). I also added a "LOAD-CONTRIB" function,
> which figures out the contrib directory from stumpwm's asdf definition
> and added some exports.
>
> Comments?
Looks good. I see you cleaned up defun-cached a bit - do you and Shawn
think it could be generally useful enough to move out of contrib/? Or
maybe just move to a shared file for contrib modules.
Also, battery-sysfs.lisp is probably a better name because
battery.lisp also only works on Linux (I believe), but doesn't use
/sys/.
Thanks,
John
Re: [STUMP] [PATCH] Add battery2.lisp - works with multiple batteries, uses sysfs., Vitaly Mayatskikh, 2008/07/24