Re: [STUMP] [PATCH] Add battery2.lisp - works with multiple batteries, uses sysfs.

[Julian Stecklina]

John Li <address@hidden> writes:

> On Mon, Jul 21, 2008 at 03:03:35AM +0200, Julian Stecklina wrote:
>>
>> I renamed your hacked read-line for SBCL to read-line-from-sysfs and
>> moved it to wrappers.lisp, since at least the cpu contrib could use the
>> same overhaul (and workaround). I also added a "LOAD-CONTRIB" function,
>> which figures out the contrib directory from stumpwm's asdf definition
>> and added some exports.
>> 
>> Comments?
>
> Looks good. I see you cleaned up defun-cached a bit - do you and Shawn
> think it could be generally useful enough to move out of contrib/? Or
> maybe just move to a shared file for contrib modules.

I would suggest moving that into cl-utilities and introducing that as
dependency.

> Also, battery-sysfs.lisp is probably a better name because
> battery.lisp also only works on Linux (I believe), but doesn't use
> /sys/.

The idea was that after some time when no serious problems with the
sysfs approach are discovered, the old battery.lisp will be
removed. There is no point keeping duplicate work around.

I did want to emphasize that this contribution only works on Linux, I
guess most users don't care how. I considered renaming battery.lisp to
battery-legacy.lisp, but that would have broken people's init scripts.

Regards,
-- 
Julian Stecklina

Well, take it from an old hand: the only reason it would be easier to
program in C is that you can't easily express complex problems in C,
so you don't. - Erik Naggum (in comp.lang.lisp)

(Spam-Experiment: http://cthulhu.c3d2.de/~astro/badpit.html )