Re: [STUMP] [PATCH] Add battery2.lisp - works with multiple batteries, uses sysfs.

[Luca Capello]

Hi there!

On Mon, 21 Jul 2008 23:07:25 +0200, Julian Stecklina wrote:
> John Li <address@hidden> writes:
>> Also, battery-sysfs.lisp is probably a better name because
>> battery.lisp also only works on Linux (I believe), but doesn't use
>> /sys/.
>
> The idea was that after some time when no serious problems with the
> sysfs approach are discovered, the old battery.lisp will be
> removed. There is no point keeping duplicate work around.
>
> I did want to emphasize that this contribution only works on Linux, I
> guess most users don't care how. I considered renaming battery.lisp to
> battery-legacy.lisp, but that would have broken people's init scripts.

Without having ever looked at battery.lisp nor battery2.lisp (or
whatever the new name is), I'd suggest to merge both of them, giving
preference to the sysfs interface, for different reasons:

1) end users shouldn't care about which interface is used (/proc
   vs. /sys), they want the battery status

2) other projects do like that, ATM I only remember acpiclient [1], but
   I'd guess that Emacs will follow soon [2]

3) nothing will break, because we have only one battery.lisp :-)

Just my 0.02€...

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://acpiclient.cvs.sourceforge.net/acpiclient/acpi/acpi.c?r1=1.1&r2=1.2
[2] lisp/battery.el still contains the old function for APM

pgpLQQjw7hOs3.pgp
Description: PGP signature