Re: [STUMP][CONTRIB] Tag-based window management

[Julian Stecklina]

Raskin Michael <address@hidden> writes:

> (defcommand window-tags (&optional (argwin nil)) ()
>           "Show window tags"
>       (let* ((win (or argwin (current-window)))
>              (tags (xlib:get-property (window-xwin win) :STUMPWM_TAGS))
>              (tagstring (utf8-to-string tags))
>              (taglist 
>                (if tags (with-input-from-string (tagstream tagstring) (read 
> tagstream)) nil)
>                )
>              )
>         (if argwin taglist (message "Tags: ~{~%~a~}" taglist))))

Some general comments:
 - You use READ without *READ-EVAL* bound to NIL. READ is generally a
   bad idea for everything that is not a quick hack IMHO. 

 - A line with only a ) violates StumpWM's style.

 - You use INTERN without binding *PACKAGE* to something sensible.

 - Interned symbols are never garbage collected (unless
   uninterned). Creating interned symbols at runtime and never disposing
   of them is IMHO problematic. You could just as well use strings to
   represent tags. 

Regards,
-- 
Julian Stecklina

The day Microsoft makes something that doesn't suck is probably the day
they start making vacuum cleaners - Ernst Jan Plugge