Re: [STUMP] improvements of floating-group

[Ben Spencer]

On Thu, Dec 16, 2010 at 01:53:12PM +0100, Manuel Giraud wrote:
> I've set up a repo with some improvements I'm making (mostly for the
> floating-group). You can clone/pull it from here:
> 
>  $ git clone http://repo.44.lt/stumpwm.git


Hi Manuel,

I've had a look through your patches.  Comments below.  I've also
rebased them against the current master at
https://github.com/dangerousben/stumpwm/tree/float, which you may find
useful because there were some conflicts.


Saner default for floating policy in floating-group.

I agree that having click-to-focus by default in float groups makes
sense, but it seems non-intuitive to do this when *mouse-focus-policy*
is :ignore.  Perhaps we should allowing configuring the focus policy
on a per-group-type basis, and default it to :click for float groups.


focus everywhere in the window

Makes sense.


warp pointer in right corner when resizing in float group

Cool.


Focus/unfocus colors already exist. Use them in float-group instead of
hardcoded colors.

Not sure about this, partly because I have both colours set to black,
and a black background, so the window borders become invisible :(
Perhaps another thing that would benefit from being configurable
per-group-type (ideally I'd like some kind of mechanism that would let
the user choose a global default and then optionally override it for
different group types).


Use float-window-move-resize instead of a raw setf to move.

Fine.


Ben