Re: [STUMP] improvements of floating-group

[Lionel Flandrin]

On Thu, Mar 10, 2011 at 08:21:08PM +0000, Ben Spencer wrote:
> On Thu, Dec 16, 2010 at 01:53:12PM +0100, Manuel Giraud wrote:
> > I've set up a repo with some improvements I'm making (mostly for the
> > floating-group). You can clone/pull it from here:
> > 
> >  $ git clone http://repo.44.lt/stumpwm.git
> 
> 
> Hi Manuel,
> 
> I've had a look through your patches.  Comments below.  I've also
> rebased them against the current master at
> https://github.com/dangerousben/stumpwm/tree/float, which you may find
> useful because there were some conflicts.
> 
> 
> Saner default for floating policy in floating-group.
> 
> I agree that having click-to-focus by default in float groups makes
> sense, but it seems non-intuitive to do this when *mouse-focus-policy*
> is :ignore.  Perhaps we should allowing configuring the focus policy
> on a per-group-type basis, and default it to :click for float groups.
> 
> 
> focus everywhere in the window
> 
> Makes sense.
> 
> 
> warp pointer in right corner when resizing in float group
> 
> Cool.
> 
> 
> Focus/unfocus colors already exist. Use them in float-group instead of
> hardcoded colors.
> 
> Not sure about this, partly because I have both colours set to black,
> and a black background, so the window borders become invisible :(
> Perhaps another thing that would benefit from being configurable
> per-group-type (ideally I'd like some kind of mechanism that would let
> the user choose a global default and then optionally override it for
> different group types).

Well, you have to admit your setup is pretty peculiar :). Maybe you
could just choose to use a non-black background, after all in stump
you hardly ever see it in tiling-groups so it wouldn't really hurt to
have one specially for the floating groups, would it?

If you really want something per group type, I think it would be an
option to turn the borders on or off, per group colours souds a bit
bloated to me.

Also, it would be quite easy to set per group or per group type
backgrounds by hooking *focus-group-hook*.

After all, one of the selling points of stumpwm is "no more themes",
isn't it? :)

> 
> Use float-window-move-resize instead of a raw setf to move.
> 
> Fine.
> 
> 
> Ben

Cool to see someone working on the floating-groups, it needs some
love.

Cheers,
-- 
Lionel Flandrin

pgpj5rYo771ZF.pgp
Description: PGP signature