Re: [STUMP] group-format-map and window-format-map

[Matt Spear]

Fixed the 0 index not existing.  Fixed the group map.  Removed the
print.  Made the #\n default to the X-map-number (and fixed doc).

It would be nice to integrate this further, but there are some
subtelities.  The gselect command allows selecting a group via a
substring, and in the general case the group-number-map map will be
non-digits (as I have it now).  Maybe the gselect command will default
to the map index if it is a single character and exists in the
group-number-map, otherwise will attempt a substring search on the
groups?

Thanks!!!
Matt Spear
address@hidden



On Wed, Mar 16, 2011 at 11:23 AM, Ben Spencer <address@hidden> wrote:
> On Tue, Mar 15, 2011 at 09:37:56PM -0700, Matt Spear wrote:
>> Having the windows be stuck with 0-based while groups can be 1-based
>> is annoying (and there may be ppl like me that want more generic
>> maps).  To accomidate this I added a *group-format-map* and a
>> *window-format-map*, both of which can be accessed via %f in the
>> *group-format*/*window-format*.  In both cases once the map is
>> exceeded the actual window-number or group-number is used.
>
> Hi Matt,
>
> Great, this is a much-requested feature.  Some minor comments:
>
>> (n (if (eq num 0) 10 num))
>
> A group number never will be 0 in the current implementation so I
> think this is unnecessary.
>
>> (prin1-to-string n)
>> (prin1-to-string num)
>
> This explicit conversion to string is probably not needed.
>
>> (defvar *group-number-map* "0123456789")
>
> Should perhaps be "1234567890"?
>
>> (#\f window-map-number)
>> (#\f group-map-number)
>
> Might be better just to replace the existing \#n modifier and ensure
> that by default the functions behave equivalently to how window-number
> and group-number do now (I think they will with the modification to
> *group-number-map* suggested above).
>
> Ultimately (this need not affect this patch) I'd like to see this
> integrated further, eg using these mappings in the window and group
> selection commands.  This would hopefully put us in a position to
> change the group indexing to be zero-based like everything else,
> without breaking existing behaviour.
>
> Ben
>
> _______________________________________________
> Stumpwm-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/stumpwm-devel
>

window-map.patch
Description: Text Data