[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] It seem I pull code in wrong way. How can I revert it

From: Pursuer
Subject: Re: [Tinycc-devel] It seem I pull code in wrong way. How can I revert it?
Date: Sat, 12 Sep 2020 21:50:47 +0800

Thanks a lot for your rearranging and advice.

by the way I'm sure I only add tcc.h to the commit "misplaced parenthese around...", So I'm also confused about the side-effect mentioned by Christian Jullien. (In fact I had cloned a new copy before rearranging, In which the additions made by Kyryl on 22_floating_point.c was not removed.)

------------------ Original ------------------
From: "tinycc-devel" <grishka@gmx.de>;
Date: Sat, Sep 12, 2020 01:54 PM
To: "tinycc-devel"<tinycc-devel@nongnu.org>;
Subject: Re: [Tinycc-devel] It seem I pull code in wrong way. How can I revert it?

avih via Tinycc-devel wrote:
> While force-pushing is usually possible, I'd argue that at the tcc repo
> (and generally elsewhere too, but to each his own practices) no one
> should force push except maybe maintainers and maybe other regular
> contributors which 100% know what they're doing when force-pushing.

So I did put on my "maintainer hat" in this case.

Pursuer2's patch "misplaced parenthese around ..." is now on top of
mob as it was before his pushes.  Kyryl's patch "fix float to u64..."
still has bugs (<< vs >>) and adds bad formatting unnecessarily.

To all:

In the future, please use git cherry-pick or git rebase to put
your patches on top of the current public mob branch, first.

And as always:
* test before you push.

* don't add tabs and use 4 spaces to indent.  (Don't use emacs or
   configure appropriately its automatisms.).

* don't change lines that you did not change.


--- gr

> I.e. if you want something reverted at the mob repo, please ask here
> at the mailing list and one of the regulars will judge how to handle
> the request, IMHO.
> - avih

Tinycc-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]