Re: [Tinycc-devel] Plan9 extensions

[grischka]

Elijah Stone wrote:
> I should clarify: these are not extensions to make tcc run on plan9 or
> target it.  They are just regular extensions which happen to originate
> in plan9.  They're also implemented by gcc; see documentation at
> https://gcc.gnu.org/onlinedocs/gcc/Unnamed-Fields.html

While nicely done formally I would think these patches still seem to
add quite a lot of 'td' (mostly mentioned in combination with '= 0;'
or '= td;') for a rather obscure feature.

Did you eventually consider to introduce yourself to tinycc with something
more commonly useful, ideally within a range that you would be able to
handle easily, already? ;)

-- gr

> On Sun, 16 May 2021, Christian Jullien wrote:
>
> > Hi, I'm not an official maintainer so I can't tell you to push the
> > patches.
> > However, I suggest you surround Plan9 extensions with something like:
> >
> > #ifdef TCC_TARGET_PLAN9
> > #endif
> >
> > Also have a look at conftest.c
> >
> > To summarize, if adopted, your patches related to plan9 should be
> > detected
> > by ./configure and protected by TCC_TARGET_PLAN9 and, if needed, also
> > adapt
> > the test suite accordingly.
> > Maintainers will decide what to do with your other patches improving the
> > quality of error messages.
> >
> > IMHO, it's more important (for you) to start with PLAN9 support and later
> > propose a second and unrelated patch for the error messages.
> >
> > My concern is also how you'll maintain the Plan9? Ideally, you should
> > be the
> > Plan9 maintainer and test about every commits to see if Plan9
> > continues to
> > work with mod.
> >
> > M2c.
> >
> > C.
> >
> > -----Original Message-----
> > From: Tinycc-devel
> > [mailto:tinycc-devel-bounces+eligis=orange.fr@nongnu.org]
> > On Behalf Of Elijah Stone
> > Sent: Sunday, May 16, 2021 01:39
> > To: tinycc-devel@nongnu.org
> > Subject: [Tinycc-devel] Plan9 extensions
> >
> > Hi all,
> >
> > Attached patches implement the plan9 extensions to c, also implemented by
> > gcc&co.  It also improves the quality of error messages for code using
> > typedefs.
> >
> > I've split the patch into two parts: the first implements the simpler
> > half
> > of the extension and the error improvements, while the second, which
> > implements the other half of the extension, is somewhat invasive and
> > may not
> > be worthwhile to support.  (Particularly since it can be simulated
> > in-userspace using _Generic.)
> >
> > Cheers,
> >
> >  -E
> >
> >
> > _______________________________________________
> > Tinycc-devel mailing list
> > Tinycc-devel@nongnu.org
> > https://lists.nongnu.org/mailman/listinfo/tinycc-devel
>
> _______________________________________________
> Tinycc-devel mailing list
> Tinycc-devel@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel