Re: [Monotone-devel] commit ignores _MTN/options keydir

[Derek Scherger]

Stephen Leake wrote:
> Derek Scherger <address@hidden> writes:
> > I committed a change yesterday that sets a default value for the
> > --keydir option for non-workspace commands (CMD_NO_WORKSPACE) in rev
> > 65ac5a3fda02533e30468090f63f82e3674cac73.
>
> This also fixes my bug.

Ok, good, that's encouraging.

> I've checked in my new test anyway, to ensure the bug does not come
> back. I verified it fails with mtn 0.39.

Also good.

> > This prevents hitting another invariant on an empty key directory
> > (i.e. the keydir name is "") also in the key_store. Unfortunately,
> > this "fix" also seems to trigger another invariant in
> > workspace::get_ws_options (work.cc:454) I(opts.key_dir.empty())'
> > which requires that there is no default keydir.
>
> I fixed this by deleting that invariant.
>
> There is consequence of these changes; 'mtn sync' now appears to
> require an explicit --key option. And it is also not respecting keydir
> in _MTN/options; more work to do :(>

Crap! I'll have a look at some point in the next few days. At the moment 
I'm fiddling on the nuskool branch though.

Cheers,
Derek