Re: [Monotone-devel] [bug #29576] mtn tries to rewrite options file every time

[Thomas Keller]

Am 18.04.10 00:53, schrieb Derek Scherger:
> On Sat, Apr 17, 2010 at 1:27 AM, Thomas Keller <address@hidden>wrote:
>> 2) Only save those options back to _MTN/options which have actually been
>> given by the user on the command line - this would probably need a little
>> fiddling with the <someopt>_given flag we set even for options from
>> _MTN/options (or we leave that alone and find another way to determine
>> which
>> options have been given by the user and which not). Note that there is also
>> a
>> hook which returns default command options for a command.
>> Alternatively we could always save back the options to _MTN/options unless
>> another global command line option is given, f.e. --skip-options-saving or
>> something similar.
>>
> 
> How about something simple:just before writing out a new _MTN/options read
> in the current one and see if there is any difference between what is about
> to be written and what is already written, then only write out new options
> if there are *actual* changes. This should be entirely compatible with what
> we do now, but will avoid affecting the last modification time when nothing
> is actually changed.

Yes, this sounds very reasonable. I'm a bit hesitant when new options
(especially in global scope) are introduced, because we have quite a lot
already and some of them have only been introduced for very little use
cases or what I like to call "pseudo functionality".

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature