Re: [Monotone-devel] [bug #29576] mtn tries to rewrite options file every time

[Thomas Keller]

Am 19.04.2010 03:22, schrieb Derek Scherger:
> On Sun, Apr 18, 2010 at 2:40 PM, Thomas Keller <address@hidden
> <mailto:address@hidden>> wrote:
> 
> 
>     Heh, very cool, thanks Derek! Does this code change also fix the problem
>     that _MTN/options is written out even if the command does not succeed?
> 
> 
> I don't think so.  This change was to the set_options function in
> work.cc. The places that call this explicitly do so very late so there's
> not much left to fail.
> 
> This function is also called by some of the workspace constructors which
> is probably where the trouble is... create a workspace and write out any
> changed options before doing something that might fail. Presumably these
> places should all be changed to explicitly call set_options after
> they've finished whatever they're doing so that failures wouldn't result
> in changed options.

Right, take this example here for an existing workspace:

$ mtn db init -d other.mtn
$ mtn status -d other.mtn
mtn: misuse: parent revision c0057626add3fd7d46d868700f3feef1f1930e15
does not exist, did you specify the wrong database?
$ mtn status
mtn: misuse: parent revision c0057626add3fd7d46d868700f3feef1f1930e15
does not exist, did you specify the wrong database?

I tried to address this issue in
0db915193923a54f43d91a67688e2fc4f8641683 and it seems to work (for the
above case) - lets see what the other functional tests say.

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature