Re: [Monotone-devel] changelog editor issues

[Markus Wanner]

Hi,

On 09/05/2010 09:37 AM, Stephen Leake wrote:
> I've read thru the email thread [2]. There is overwhelming support for
> moving the changelog comment to the top, possibly with a small header.

+1, the proposed change log format looks a lot cleaner and seems easier 
to used and understand.

Are we sure we don't need anything that states where to put the commit 
message itself? I mean, it's obvious to me and you, but will a newbie on 
Windows know what to do with the Notepad.exe that's suddenly popping up?

> "
>
> *** MODIFY OR REMOVE THIS LINE TO CANCEL THE COMMIT ***
> --Edit fields beneath this line to modify certificate values--
> Branch:   uk.co.unchartedbackwaters.simple_cfd.tensor.expr.cse
> Author:   Francis Russell<example<at>  example.com>
> Date:     21/07/10 13:35:29
>
> --Modifications under this line are ignored entirely--
> Changes against parent bd846e89bef8324b758f8a2c6e7dde41aa4ddd9d
>
>    patched  include/simple_cfd/cse/cse_optimiser.hpp
>    patched  include/simple_cfd/numeric/ginac_expression.hpp
> "

Nitpick mode: isn't it rather 'below this line'?

> There was discussion of whitespace trimming; with this format, only
> trailing blank lines need to be trimmed from the commit comment.

+1

> There was a suggestion to allow editing the changelist section, to
> exclude files from commit (similar to the --exclude command line
> option). That is complicated; let's leave that for later, or at least in
> a separate discussion.

Yeah, leave that for later perfection.

> I propose that we adopt this format, with the addition of a 'key: '
> line under the 'Author: ' line; any objections?

+1

Regards

Markus Wanner