Re: grub-0.93-win32-iso9660.diff

[Yoshinori Okuji]

 --- Robert Millan <address@hidden> wrote: > 
> I'm interested in your grub-0.93-win32-iso9660.diff patch and would like
> to get it integrated in GRUB CVS.

That is not your task: One who decides if a feature should be added is the
maintainer (at least, ultimately). In this project, it is ok for you to commit
any patch yourself, but only if it is just a bug fix or it is approved by the
maintainer (i.e. me).

As I have been saying many times, adding a new feature must be a conservative
process. Otherwise, you will get many bugs and enourmous complaints from the
users, and you will have difficulty in keeping backward compatibility.

Please follow this rule: do not add any new features unless they are critical,
until 1.0 is released.

Are you sure that the features would not unstabilize the existing features? Is
the code clean enough? It the code consistent with the existing code? Is there
any good documentation? Do you believe that the implementation is the best way
to realize such features?

If you still think the patch should be applied even after reading those
questions, please send me the changelog and a short documentation about how to
use the new features. Then, I will judge.

Regards,
Okuji

P.S. I think you now understand why it is important to be a maintainer. :)