chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] Fix solaris9 build for missing trunc, round, isinf


From: Michele La Monaca
Subject: Re: [Chicken-hackers] Fix solaris9 build for missing trunc, round, isinf math functions
Date: Sat, 20 Apr 2013 17:18:07 +0200

I've spotted an error in the patch.

static inline double trunc(double x) { return (x > 0 ? floor(x) :
floor(x) + 1); }

should be:

static inline double trunc(double x) { return (x >= 0 ? floor(x) :
floor(x) + 1); }

please correct it before pushing.

Thanks!

Michele


On Sat, Apr 20, 2013 at 5:12 PM, Christian Kellermann
<address@hidden> wrote:
> * felix winkelmann <address@hidden> [130420 16:56]:
>> From: Michele La Monaca <address@hidden>
>> Subject: [Chicken-hackers] Fix solaris9 build for missing trunc, round, 
>> isinf math functions
>> Date: Wed, 17 Apr 2013 23:48:19 +0200
>>
>> > This patch fixes Solaris 9 compilation (suncc) which fails due to
>> > missing C99 math functions.
>>
>> Thanks - signed off and pushed.
>
> On a second thought, neither Peter nor I can find this in the usual
> place. Did you really push it?
>
> Sorry for the lecturing...
>
> Christian
>
> --
> In the world, there is nothing more submissive and weak than
> water. Yet for attacking that which is hard and strong, nothing can
> surpass it. --- Lao Tzu



reply via email to

[Prev in Thread] Current Thread [Next in Thread]