Re: [Chicken-hackers] [PATCH] fix for srfi-13 string-trim-right start parameter

[Seth Alves]

Here's a patch with both msg00007's patch and the modified
string-trim-right patch included.  The differences in let-optionals*
have already been (mostly) smoothed over in CHICKEN's version, I'm
reluctant to mess with that.

    -seth


On 01/11/2014 10:28 AM, John Cowan wrote:
> .alyn.post. scripsit:
>
>> Did you review the, uh "rest" of sfri-13 to see if this pattern is
>> repeated elsewhere?  I'd suspect the implementor, making this
>> mistake, would make it in multiple places.
> It's definitely not a problem in string-trim or string-trim-both:
>
> #;2> (string-trim "x    abc" char-whitespace? 1)
> "abc"
> #;3> (string-trim-both "x   abc   " char-whitespace? 1)
> "abc"
>
> The bug fix given in
> <http://srfi.schemers.org/srfi-13/post-mail-archive/msg00007.html>
> should also be applied, as it is still present in the Chicken version.
>
> Someone should also verify that Chicken's definition
> of `let-optionals*` is the correct one for SRFI 13; see
> <http://srfi.schemers.org/srfi-13/post-mail-archive/msg00008.html>,
> <http://srfi.schemers.org/srfi-13/post-mail-archive/msg00009.html>,
> and <http://srfi.schemers.org/srfi-13/post-mail-archive/msg00010.html>
> for discussion.
>

srfi-13-string-trim-right-1.patch
Description: Text Data