Re: [Chicken-hackers] [PATCH] fix for srfi-13 string-trim-right start parameter

[Seth Alves]

(string-trim-right "abc   " char-whitespace? 1)

pre-patch: "abc", which is wrong.

post-patch: "bc", which is right.

    -seth


On 01/11/2014 12:26 PM, Mario Domenech Goulart wrote:
> On Sat, 11 Jan 2014 11:23:52 -0800 Seth Alves <address@hidden> wrote:
>
>> Here's a patch with both msg00007's patch and the modified
>> string-trim-right patch included.  The differences in let-optionals*
>> have already been (mostly) smoothed over in CHICKEN's version, I'm
>> reluctant to mess with that.
> Thanks a lot, Seth.  Attached is the patch by David Van Horn that you
> ported to CHICKEN.  I've added the test cases David provided and
> formatted for git.
>
> With regard to the string-trim-right, I still get
>
>    (string-trim-right "abc   " char-whitespace? 1) => "bc"
>
> after applying your patch, which we concluded was wrong, no?
>
> Best wishes.
> Mario