[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] fix for srfi-13 string-trim-right start pa
|
From: |
Mario Domenech Goulart |
|
Subject: |
Re: [Chicken-hackers] [PATCH] fix for srfi-13 string-trim-right start parameter |
|
Date: |
Sat, 11 Jan 2014 20:26:48 +0000 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
On Sat, 11 Jan 2014 11:23:52 -0800 Seth Alves <address@hidden> wrote:
> Here's a patch with both msg00007's patch and the modified
> string-trim-right patch included. The differences in let-optionals*
> have already been (mostly) smoothed over in CHICKEN's version, I'm
> reluctant to mess with that.
Thanks a lot, Seth. Attached is the patch by David Van Horn that you
ported to CHICKEN. I've added the test cases David provided and
formatted for git.
With regard to the string-trim-right, I still get
(string-trim-right "abc " char-whitespace? 1) => "bc"
after applying your patch, which we concluded was wrong, no?
Best wishes.
Mario
--
http://parenteses.org/mario
0001-Fix-bug-in-string-index-right-and-string-skip-right.patch
Description: Text Data
Re: [Chicken-hackers] [PATH] fix for srfi-13 string-trim-right start parameter, .alyn.post., 2014/01/11
Re: [Chicken-hackers] [PATH] fix for srfi-13 string-trim-right start parameter, Mario Domenech Goulart, 2014/01/11
Re: [Chicken-hackers] [PATH] fix for srfi-13 string-trim-right start parameter, Mario Domenech Goulart, 2014/01/19
Re: [Chicken-hackers] [PATH] fix for srfi-13 string-trim-right start parameter, John Cowan, 2014/01/22
Re: [Chicken-hackers] [PATH] fix for srfi-13 string-trim-right start parameter, Alex Shinn, 2014/01/22