Re: [Chicken-hackers] ⍄PATCH⍃ Unboxing optimization for flonums

[Mario Domenech Goulart]

Hi,

On Thu, 29 Nov 2018 11:42:36 +0100 address@hidden wrote:

>> On Wed, Nov 28, 2018 at 07:25:33PM +0100, Mario Domenech Goulart wrote:
>> > It looks like this patch (79cf7427, master) has broken "make
>> > bootstrap".  Log attached (using CHICKEN 5.0.0 as CHICKEN).
>> 
>> Right you are.  The reason is that lfa2 is trying to unbox the arguments
>> to {f32,f64}_vector_ref, which are not flonums but srfi-4 vector and
>> integer arguments.  The return value is a flonum.
>> 
>> Attached is a patch to avoid unboxing the argument to accessor functions.
>
> Sorry about this. Pushed.

No problem.  Unfortunately, now "make check" breaks:

Error: assertion failed: (eqv? (f32vector-ref old 6) (f32vector-ref new 0))

        Call history:

        <eval>    (=598 i596 7)
        <eval>    (make-locative601 old593 i596)
        <eval>    (make-locative601 new594 (|-603| 7 i596 1))
        <eval>    (|-603| 7 i596 1)
        <eval>    (locative?605 loc-src600)
        <eval>    (locative?605 loc-dst602)
        <eval>    (locative-set!606 loc-dst602 (locative-ref607 loc-src600))
        <eval>    (locative-ref607 loc-src600)
        <eval>    (doloop612 (add1597 i596))
        <eval>    (add1597 i596)
        <eval>    (=598 i596 7)
        <eval>    (printf608 "\nold: ~S\nnew: ~S\n" old593 new594)
        <eval>    (eqv?609 (f32vector-ref old593 6) (f32vector-ref new594 0))
        <eval>    (f32vector-ref old593 6)
        <eval>    (f32vector-ref new594 0)
        <eval>    (##sys#error "assertion failed" (##core#quote (eqv? 
(f32vector-ref old 6) (f32vector-ref new 0))))    <--
rules.make:975: recipe for target 'check' failed
make: *** [check] Error 70

All the best.
Mario
-- 
http://parenteses.org/mario