[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Towards a cleaner build: rmailmm
From: |
Lars Ingebrigtsen |
Subject: |
Re: Towards a cleaner build: rmailmm |
Date: |
Thu, 13 Jun 2019 14:44:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
In rmail-mime-insert-bulk:
mail/rmailmm.el:839:21:Warning: `string-as-unibyte' is an obsolete function
(as of 26.1); use `encode-coding-string'.
So, it's this code:
(defun rmail-mime-insert-bulk (entity)
"Presentation handler for an attachment MIME entity."
[...]
(if (stringp (aref body 0))
(setq data (aref body 0))
(setq data (string-as-unibyte (buffer-string)))
(aset body 0 data)
(rmail-mime-set-bulk-data entity)
(delete-region (point-min) (point-max)))
I've stared at the code some, but I'm not totally sure what it's doing
here. But... wouldn't string-to-unibyte be the right thing here
anyway?
I'm not an rmail user, so I can't test this.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- Re: Towards a cleaner build, (continued)
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/06/09
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/06/09
- Re: Towards a cleaner build, Eli Zaretskii, 2019/06/11
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/06/12
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/06/12
- Re: Towards a cleaner build, Stefan Monnier, 2019/06/12
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/06/12
- Re: Towards a cleaner build, Stefan Monnier, 2019/06/13
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/06/13
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/06/13
- Re: Towards a cleaner build: rmailmm,
Lars Ingebrigtsen <=
- Re: Towards a cleaner build: rmailmm, Stefan Monnier, 2019/06/13
- Re: Towards a cleaner build: rmailmm, Eli Zaretskii, 2019/06/14
- Re: Towards a cleaner build: rmailmm, Stefan Monnier, 2019/06/14
- Re: Towards a cleaner build: rmailmm, Lars Ingebrigtsen, 2019/06/14
- Re: Towards a cleaner build: eieio, Lars Ingebrigtsen, 2019/06/13
- Re: Towards a cleaner build: eieio, Stefan Monnier, 2019/06/13
- Re: Towards a cleaner build: eieio, Lars Ingebrigtsen, 2019/06/14
- Re: Towards a cleaner build: eieio, Stefan Monnier, 2019/06/14
- Re: Towards a cleaner build: eieio, Lars Ingebrigtsen, 2019/06/14
- Re: Towards a cleaner build: eieio, Stefan Monnier, 2019/06/14