Re: "modern" colors Re: Changes for emacs 28

[Robert Pluim]

>>>>> On Mon, 14 Sep 2020 16:20:19 -0400, Stefan Monnier 
>>>>> <monnier@iro.umontreal.ca> said:

    >> I don’t understand.  There is a clear problem here in that the
    >> font-lock-comment-face is dark red and the region colour is whatever the
    >> GTK theme says it should be.  So unless font-lock-comment-face is also
    >> set according to the GTK theme’s colours there is no way to avoid this
    >> unfortunate combination of colours (dark red on dark background) without
    >> customization.

    Stefan> Does Gtk offer some setting for the color of "comments"?
    Stefan> What do other applications do?

    >> FWIW neither the dark red colour nor the region background colour
    >> changes when I change frame-background-mode.

    Stefan> Maybe there's a bug here.  The color of `font-lock-comment-face`
    Stefan> *should* change.  If you can reproduce this, please provide a 
recipe to
    Stefan> `report-emacs-bug`.  The code says:

    Stefan>     (defface font-lock-comment-face
    Stefan>       '((((class grayscale) (background light))
    Stefan>          :foreground "DimGray" :weight bold :slant italic)
    Stefan>         (((class grayscale) (background dark))
    Stefan>          :foreground "LightGray" :weight bold :slant italic)
    Stefan>         (((class color) (min-colors 88) (background light))
    Stefan>          :foreground "Firebrick")
    Stefan>         (((class color) (min-colors 88) (background dark))
    Stefan>          :foreground "chocolate1")
    Stefan>         (((class color) (min-colors 16) (background light))
    Stefan>          :foreground "red")
    Stefan>         (((class color) (min-colors 16) (background dark))
    Stefan>          :foreground "red1")
    Stefan>         (((class color) (min-colors 8) (background light))
    Stefan>          :foreground "red")
    Stefan>         (((class color) (min-colors 8) (background dark))
    Stefan>          :foreground "yellow")
    Stefan>         (t :weight bold :slant italic))
    Stefan>       "Font Lock mode face used to highlight comments."
    Stefan>       :group 'font-lock-faces)

    Stefan> So when in "dark background" mode, `font-lock-comment-face` should 
be
    Stefan> using `chocolate1` rather than `Firebrick`.

The GTK theme may be in 'dark' mode, but (as discussed elsewhere in
this thread), the default face does not respect the GTK theme
background.

Robert