Re: Xref completion

[Dmitry Gutov]

On 03.12.2020 23:09, Juri Linkov wrote:
> > > BTW, like you created xref--show-defs-minibuffer
> > > as a possible option for xref-show-definitions-function,
> > > wouldn't it be also nice to do the same and create
> > > xref--show-xref-minibuffer as a possible option for
> > > xref-show-xrefs-function?
> >
> > Don't you usually want to iterate across multiple results, when the command
> > is project-find-regexp or xref-find-references? Then the same logic will
> > not work.
>
> Right, xref--show-xref-minibuffer would be not as useful as
> xref--show-defs-minibuffer is.  Hope to see xref--show-defs-minibuffer
> in xref.el soon.

I've pushed it now with some changes, hope you all like the result.

Shortening the group part (in most common cases) is among them.

Also added some highlighting with corresponding xref faces. It now looks 
closer to Pierre's original screenshot.

Removed the bit of logic that hid the summaries when they are 
technically unnecessary because in my testing it made completion 
slightly less useful by hiding information (sorry). Anybody who really 
preferred the previous version, please try it again with c86dc8d488 
reverted locally, and maybe propose a user option for that behavior.

BTW, Juri, how do you think this new function compares against 
xref--show-defs-buffer-at-bottom?

On the one hand, it feels kinda faster, on the other, it lacks the 
ability to "look around" when you really need it. In an ideal world, I 
guess the UI would be somewhere in the middle.