Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues

[Eli Zaretskii]

> Date: Mon, 12 Jun 2023 16:11:03 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> Sorry, I have no idea what this failure means.  In particular, the
> value is correct for the defcustom, and works in practice, and also
> fits the type of the defcustom (AFAICT).
> 
> The checks that cus-test.el does are not documented in any meaningful
> way, and its output is not useful.  I didn't even know we had such a
> test, and never ran it myself.

Btw, running "make test-custom-opts" in test/ gives me a different
error:

  make[1]: Entering directory `/d/gnu/git/emacs/branch/test'
  Running 1 tests (2023-06-12 16:19:27+0300, selector `(not (or (tag :unstable) 
(tag :nativecomp)))')
  Loading d:/gnu/git/emacs/branch/admin/cus-test.el (source)...
  Running cus-test-load-libs
  Finding files...
  Test check-for-wrong-custom-opts backtrace:
    signal(error ("find exited with status 1"))
    apply(signal (error ("find exited with status 1")))
    (setq value-7 (apply fn-5 args-6))
    (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-descri
    (if (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-de
    (let (form-description-9) (if (unwind-protect (setq value-7 (apply f
    (let ((value-7 'ert-form-evaluation-aborted-8)) (let (form-descripti
    (let* ((fn-5 #'null) (args-6 (condition-case err (let ((signal-hook-
    (closure (t) nil (let* ((fn-0 #'file-readable-p) (args-1 (condition-
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name check-for-wrong-custom-opts :document
    ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :unstabl
    ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
    ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
    ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
    eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
    command-line-1(("-L" ";." "-l" "ert" "-l" "misc/test-custom-opts.el"
    command-line()
    normal-top-level()
  Test check-for-wrong-custom-opts condition:
      (error "find exited with status 1")
     FAILED  1/1  check-for-wrong-custom-opts (0.406250 sec) at 
misc/test-custom-opts.el:33

  Ran 1 tests, 0 results as expected, 1 unexpected (2023-06-12 16:19:28+0300, 
1.453125 sec)

  1 unexpected results:
     FAILED  check-for-wrong-custom-opts

So there's more to this than meets the eye, and some code (but which
one?) which runs 'find' is probably doing that in a non-portable
fashion.  (I needed to run admin/cus-tests.el by hand to get the error
which you quote.)