emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues


From: Eli Zaretskii
Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues
Date: Mon, 12 Jun 2023 19:40:24 +0300

> From: Robert Pluim <rpluim@gmail.com>
> Cc: michael.albinus@gmx.de,  emacs-devel@gnu.org
> Date: Mon, 12 Jun 2023 17:57:00 +0200
> 
> The minimal fix would be:
> 
> diff --git a/lisp/window.el b/lisp/window.el
> index 78b0787abdb..16f16a75418 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -8776,7 +8776,7 @@ display-comint-buffer-action
>    :group 'windows
>    :group 'comint)
>  
> -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window
> +(defcustom display-tex-shell-buffer-action 
> '(display-buffer-in-previous-window)
>    "`display-buffer' action for displaying TeX shell buffers."
>    :type display-buffer--action-custom-type
>    :risky t

Fine by me, please install.

> Although if we went by analogy to `display-comint-buffer-action', it
> would have to be this:
> 
> diff --git a/lisp/window.el b/lisp/window.el
> index 78b0787abdb..0213023e495 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -7575,6 +7575,13 @@ display-buffer--same-window-action
>  Specifies to call `display-buffer-same-window'.")
>  (put 'display-buffer--same-window-action 'risky-local-variable t)
>  
> +(defvar display-buffer--in-previous-window-action
> +  '(display-buffer-in-previous-window
> +    (inhibit-same-window . t))
> +  "A `display-buffer' action for displaying in the previous window.
> +Specifies to call `display-buffer-in-previous-window'.")
> +(put 'display-buffer--in-previous-window-action 'risky-local-variable t)
> +
>  (defvar display-buffer--other-frame-action
>    '((display-buffer-reuse-window
>       display-buffer-pop-up-frame)
> @@ -8776,7 +8783,7 @@ display-comint-buffer-action
>    :group 'windows
>    :group 'comint)
>  
> -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window
> +(defcustom display-tex-shell-buffer-action 
> display-buffer--in-previous-window-action
>    "`display-buffer' action for displaying TeX shell buffers."
>    :type display-buffer--action-custom-type
>    :risky t

Why do we need an extra variable here?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]