[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues
|
From: |
Eli Zaretskii |
|
Subject: |
Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues |
|
Date: |
Mon, 12 Jun 2023 20:51:27 +0300 |
> From: Robert Pluim <rpluim@gmail.com>
> Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
> Date: Mon, 12 Jun 2023 19:10:02 +0200
>
> >>>>> On Mon, 12 Jun 2023 19:40:24 +0300, Eli Zaretskii <eliz@gnu.org> said:
>
> Eli> Fine by me, please install.
>
> Done, although we should consider having that action have
> '(inhibit-same-window . t)' in it. Maybe on master.
Definitely on master.
> >> -(defcustom display-tex-shell-buffer-action
> 'display-buffer-in-previous-window
> >> +(defcustom display-tex-shell-buffer-action
> display-buffer--in-previous-window-action
> >> "`display-buffer' action for displaying TeX shell buffers."
> >> :type display-buffer--action-custom-type
> >> :risky t
>
> Eli> Why do we need an extra variable here?
>
> We donʼt, it just looks nicer than stuffing a multi-line constant in
> the default value field.
I guess "nicer" is in the eyes of the beholder. To me, it just makes
the whole arrangement harder to read and understand.