Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues

[Robert Pluim]

>>>>> On Mon, 12 Jun 2023 16:11:03 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Michael Albinus <michael.albinus@gmx.de>
    >> Cc: Eli Zaretskii <eliz@gnu.org>
    >> Date: Mon, 12 Jun 2023 14:21:07 +0200
    >> 
    >> Eli Zaretskii <eliz@gnu.org> writes:
    >> 
    >> Hi Eli,
    >> 
    >> > branch: emacs-29
    >> > commit bdb0bc2b4e44a7d40369e10e3de825d58fe46825
    >> > Author: Eli Zaretskii <eliz@gnu.org>
    >> > Commit: Eli Zaretskii <eliz@gnu.org>
    >> >
    >> >     Fix tex-mode display-buffer issues
    >> >     
    >> >     * lisp/window.el (display-tex-shell-buffer-action): New defcustom.
    >> 
    >> This results in a test error:
    >> 
    >> --8<---------------cut here---------------start------------->8---
    >> # make -C test test-custom-opts
    >> ...
    >> The following options might have problems:
    >> variable: display-tex-shell-buffer-action
    >> value: display-buffer-in-previous-window
    >> type: (cons :tag "Action" (choice :tag "Action functions" (choice :tag 
"Function" (const :tag "--" ignore) (const display-buffer-reuse-window) (const 
display-buffer-pop-up-window) (const display-buffer-same-window) (const 
display-buffer-pop-up-frame) (const display-buffer-full-frame) (const 
display-buffer-in-child-frame) (const display-buffer-below-selected) (const 
display-buffer-at-bottom) (const display-buffer-in-previous-window) (const 
display-buffer-use-least-recent-window) (const display-buffer-use-some-window) 
(const display-buffer-use-some-frame) (function :tag "Other function")) (repeat 
:tag "List of functions" (choice :tag "Function" (const :tag "--" ignore) 
(const display-buffer-reuse-window) (const display-buffer-pop-up-window) (const 
display-buffer-same-window) (const display-buffer-pop-up-frame) (const 
display-buffer-full-frame) (const display-buffer-in-child-frame) (const 
display-buffer-below-selected) (const display-buffer-at-bottom) (const 
display-buffer-in-previous-window) (const 
display-buffer-use-least-recent-window) (const display-buffer-use-some-window) 
(const display-buffer-use-some-frame) (function :tag "Other function")))) 
(alist :tag "Action arguments" :key-type symbol :value-type (sexp :tag 
"Value")))
    >> --8<---------------cut here---------------end--------------->8---

    Eli> Sorry, I have no idea what this failure means.  In particular, the
    Eli> value is correct for the defcustom, and works in practice, and also
    Eli> fits the type of the defcustom (AFAICT).

Are you sure?

(defconst display-buffer--action-custom-type
  `(cons :tag "Action"
         (choice :tag "Action functions"
                 ,display-buffer--action-function-custom-type
                 (repeat
                  :tag "List of functions"
                  ,display-buffer--action-function-custom-type))
         (alist :tag "Action arguments"
                :key-type symbol
                :value-type (sexp :tag "Value")))
  "Custom type for `display-buffer' actions.")

(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window
  "`display-buffer' action for displaying TeX shell buffers."
  :type display-buffer--action-custom-type

Did you mean this instead:

(defconst display-buffer--action-function-custom-type
  '(choice :tag "Function"
           (const :tag "--" ignore) ; default for insertion
           (const display-buffer-reuse-window)

Robert
--