Re: Beets integration

[Daniel Semyonov]

>>>>> Yoni Rabkin writes:

    >> > Warning (comp): emms-bookmarks.el:76:6: Warning: value from call to 
‘sort’ is unused
    >> > Warning (comp): emms-browser.el:285:18: Warning: in defcustom for 
‘emms-browser-covers’: ‘list’ without arguments
    >> > Warning (comp): emms-browser.el:299:10: Warning: in defcustom for 
‘emms-browser-default-covers’: ‘list’ without arguments
    >> > Warning (comp): emms-metaplaylist-mode.el:50:10: Warning: in
    >> > defcustom for ‘emms-metaplaylist-mode-hooks’: ‘list’ without
    >> > arguments
    >> > Warning (comp): emms-later-do.el:75:8: Warning: ‘unwind-protect’ 
without unwind forms
    >> 
    >> I fixed these warnings.  I now get 0 warnings when installing EMMS, or
    >> when background native compilation runs for it.

    > I don't get the above errors at all. I'm not sure where they are from.

I got those using the master branch of Emacs, they might be new (a bunch
of new warnings were added since Emacs 29).

    > I get a clean compilation on 29.2 and 29.1, but I get the following
    > errors in 28.2:

    >     In emms-source-beets:
    >     emms-source-beets.el:79:47: Warning: ‘(item (sqlite-next db))’ is a 
malformed function
    >     emms-source-beets.el:79:47: Warning: ‘(item (sqlite-next db))’ is a 
malformed function
    >     emms-source-beets.el:165:50: Warning: reference to free variable 
‘item’
    >     emms-source-beets.el:180:29: Warning: reference to free variable 
‘track’
    >     emms-source-beets.el:187:13: Warning: reference to free variable 
‘path’
    >     emms-source-beets.el:169:52: Warning: assignment to free variable 
‘item’
    
    >     In end of data:
    >     emms-source-beets.el:165:18: Warning: the function ‘path’ is not 
known to be defined.
    >     emms-source-beets.el:164:18: Warning: the function ‘track’ is not 
known to be defined.
    >     emms-source-beets.el:163:6: Warning: the function ‘while-let’ is not
    >     known to be defined.

    > It is annoying to have to hunt these down in previous versions, but we
    > have been supported the last two releases.

I quickly tried converting it from `while-let' to `let' and `while'
separately, and realized my previous implementation had a potential bug,
so I'll fix it and those warnings.