Re: Beets integration

[Daniel Semyonov]

>>>>> Yoni Rabkin writes:

    > Daniel Semyonov <daniel@dsemy.com> writes:
    >>>>>>> Yoni Rabkin writes:
    >> 
    >> >> > Warning (comp): emms-bookmarks.el:76:6: Warning: value from call to 
‘sort’ is unused
    >> >> > Warning (comp): emms-browser.el:285:18: Warning: in defcustom for 
‘emms-browser-covers’: ‘list’ without arguments
    >> >> > Warning (comp): emms-browser.el:299:10: Warning: in defcustom for 
‘emms-browser-default-covers’: ‘list’ without arguments
    >> >> > Warning (comp): emms-metaplaylist-mode.el:50:10: Warning: in
    >> >> > defcustom for ‘emms-metaplaylist-mode-hooks’: ‘list’ without
    >> >> > arguments
    >> >> > Warning (comp): emms-later-do.el:75:8: Warning: ‘unwind-protect’ 
without unwind forms
    >> >> 
    >> >> I fixed these warnings.  I now get 0 warnings when installing EMMS, or
    >> >> when background native compilation runs for it.
    >> 
    >> > I don't get the above errors at all. I'm not sure where they are from.
    >> 
    >> I got those using the master branch of Emacs, they might be new (a bunch
    >> of new warnings were added since Emacs 29).

    > I don't think we need to bother with those until they are a part of a
    > release (or pre-release.) Especially if they are a moving target at this
    > point.

I agree, though in this case all warnings pointed to actual mistakes in
the code, so I don't see a reason not to fix them anyway.