[gnugo-devel] ALL_MOVE considered superfluous

[Inge Wallin]

Is there really a reason for the ALL_MOVE move reason?  This used to
be called ATTACK_BOTH_MOVE, and was later renamed ALL_MOVE, taking the
real move reasons as parameters. The idea was that it tells the move
valuator that all of the move reasons apply to the move in question.

But these semantic are already used for all the move reasons for a
particular move.  Registering an ALL_MOVE(ATTACK_MOVE, D19,
ATTACK_MOVE, E18) is exactly the same as registering the two attacks
as separate move reasons.

Can anybody see a reason for keeping ALL_MOVE?  If not, I can remove
it and simplify the evaluation.

     -Inge