Re: Re[2]: [gnugo-devel] sgf/sgfnode.c possible error

[Paul Pogonyshev]

Arend wrote:
> I am a little confused:
>
> On Thu, 16 Sep 2004, Paul Pogonyshev wrote:
> > --- sgfnode.c       12 Feb 2004 19:34:20 -0200      1.27
> > +++ sgfnode.c       16 Sep 2004 01:33:28 -0200
> > @@ -710,7 +710,7 @@ sgfStartVariant(SGFNode *node)
> >    while (node->next)
> >      node = node->next;
> >    node->next = sgfNewNode();
> > -  node->next->parent = node;
> > +  node->next->parent = node->parent;
> >
> >    return node->next;
> >  }
> > @@ -727,9 +727,8 @@ sgfStartVariantFirst(SGFNode *node)
> >    SGFNode *new_first_child = sgfNewNode();
> >
> >    new_first_child->next = old_first_child;
> > -  if (old_first_child->parent)
> > -    new_first_child->parent = old_first_child->parent;
> > -  old_first_child->parent = new_first_child;
> > +  new_first_child->parent = old_first_child->parent;
> > +
> >    if (new_first_child->parent)
> >      new_first_child->parent->child = new_first_child;
>
> Are these functions ever used in GNU Go? I see them only called from
> sgftreeStartVariant(First), which in turn are called from nowhere in GNU
> Go. Should they just be removed? What is their purpose? (Sorry I am not
> familiar with sgf/.)

See sgfAddPlay().

Paul