Re: [Gnumed-devel] GnuMed EMR browser

[Ian Haywood]

On Wed, Aug 11, 2004 at 11:48:37AM +0200, Karsten Hilbert wrote:
> Hi all,
> 
> I encourage everyone to run
> 
>  python gmEMRBrowser.py
> 
> (Use hherb.com !)
This is all very impressive.

I would suggest two things:
        - using wxHTML instead of a text box to pretty things up a bit.
(this should be simple)
        - rationalising use of SQL. Unfortunately AFAICT the VO concept
has led to a very inefficient way of interacting with the backend: a
list of IDs is fetched, then one (or more) query for each item. Really
one big query (presumably on a view) should be used, which then
populates the VOs. Although it may be better OO design that VOs
encapsulate the queries used to populate themselves, certainly on all
the machine I have access to, both local and remote access, it's just
unusably slow. Because it is *unusable*, IMHO we need to grapple with
this now, normally I would agree with the priniciple of "get it working
first, then optimise"    

Ian

pgpQrKOz60_YG.pgp
Description: PGP signature