gnumed-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnumed-devel] jl-gui et alii


From: Jerzy Luszawski
Subject: Re: [Gnumed-devel] jl-gui et alii
Date: Tue, 20 Aug 2013 07:09:52 +0200

On 19-08-2013 10:55 Karsten Hilbert <address@hidden> wrote:

> 
> I had a quick look. One thing I noticed is this:
> 
> commit 15b180028134ac98796558eb794b16f246e8faea
> Author: Jerzy Luszawski <address@hidden>
>  Date:   Tue Jul 16 03:30:01 2013 +0200
> 
>     small fix to avoid errors in v19-dem-praxis_branch-static.sql
> 
> diff --git 
> a/gnumed/gnumed/server/sql/v18-v19/static/v19-dem-praxis_branch-static.sql 
> b/gnumed/gnumed/server/sql/v18-v19/static/v19-dem-praxis_branch-static.sql
> index e9f500f..13c9223 100644
> --- a/gnumed/gnumed/server/sql/v18-v19/static/v19-dem-praxis_branch-static.sql
> +++ b/gnumed/gnumed/server/sql/v18-v19/static/v19-dem-praxis_branch-static.sql
> @@ -5,6 +5,8 @@
>  -- Author: address@hidden
>  --
>  -- ==============================================================
> +\unset ON_ERROR_STOP
> +drop table dem.praxis_branch cascade;
>  \set ON_ERROR_STOP 1
>  
>  -- --------------------------------------------------------------
> 
> 
> This is questionable (not in general, not for you or in your
> case but in the context of *standard* bootstrapping GNUmed
> databases -- which is what we need MOST people to do or else
> there's no chance we can help them with problems). Here is
> why:
> 
> *-static.sql files are assumed to be run only ONCE on the
> unadulterated previous database schema version. If that
> fails it must be run against the previous version again
> after fixing the problem.
You are totally right. Good you have noticed that.
Obviously I must have messed up something. Probably I created the table
by running the script manually, then tried to upgrade the database,
run into error and fixed it in wrong way.
This needs reverting.
Sorry for the trouble.

Now my DB fails hash checks in upgrade script, so I must introduce each
change manually. It would be much easier if DB modifications required
by my plugins were included into official schema :) Then I would be
able to run the standard script.

-- 
regards,
Jerzy Luszawski



reply via email to

[Prev in Thread] Current Thread [Next in Thread]