Re: [Gnumed-devel] GNUmed database login warnings

[Karsten Hilbert]

On Thu, Nov 21, 2013 at 09:40:56AM +0000, Jim Busser wrote:

> >> #==============================================================
> >> # There really should not be any need to
> >> # change anything below this line.
> >> #==============================================================
> > 
> > This applies to the script, not to the SQL file produced.
> 
> Now you are seemingly just being cute, because the SQL file that is produced 
> is called and run by the very script that created the SQL prior to 
> terminating. Unless you are serious and intend that the user who ran
> 
>       gm-adjust_db_settings.sh
> 
> would make a post-hoc change to the SQL file and then run it a *second* time?

That may well be necessary, namely if there are things
to modify which cannot be set when the server is
running - or even not modifiable after the cluster
has been created.

> >> and if the point of running
> >> 
> >>    gm-adjust_db_settings.sh
> >> 
> >> is to adjust the gnumed_vNN db so that it will run in some 
> >> believed-to-be-desirable way, and if what you are saying is that "logging 
> >> connections/disconnects makes sense in any case",  then my suggestion is 
> >> to revise the script to that it will in future ship with the above two
> >> 
> >>    --alter database … set log_[dis]connections ...
> >> 
> >> lines uncommented (i.e. enabled) by default.
> > 
> > Note how above those lines it says "cannot be set after server start".
>
> 1) is the point of your having included, within the script,
> line numbers 57-62 mainly or wholly for documentation,
> in order that yourself and others can know about
> possibly-needed adjustments to the db

Yes.

> 2) how can you make adjustments without a server running?

One needs to set it in postgresql.conf (and the script
should say so, and now does).

Karsten
-- 
GPG key ID E4071346 @ gpg-keyserver.de
E167 67FD A291 2BEA 73BD  4537 78B9 A9F9 E407 1346