Re: Themeing

[Fred Kiefer]

Hi Christopher,

there is a small but very annoying problem with your patch for gui: You
added some clean up of he formatting to it. Now it is great to replace
the tab characters that went into the files with spaces. After noticing
that my editor used tabs instead of spaces for indentation I switched
that off and started to clean up files myself, each time I do a commit
on GNUstep. But having to proofread a huge patch with mostly whitespace
changes is rather boring. It is too easy to miss out on the important
bits, while skipping over the formatting changes.
Also your indentation does not match with the formatting rules for
GNUstep. You use

if (XXX)
{
  [AAA bb];
}

whereas GNUstep has

if (XXX)
  {
    [AAA bb];
  }

(There are other differences as well, but this is the most prominent)
Could you please switch over to the GNUstep style before doing a huge
commit?
For the changes to the comments, I also don't see why the reformatting
was necessary.

As much as I like some of the stuff you did with the Windows themes, in
the current form this patch is not ready for a review.
Have your thought about moving your NSColor code into a separate
application that will just change the system colour list and write it
out? Your code is great for most cases, but when somebody tries to
access the system colour list the result will be totally different.

The theming extensions for menu and scrollers are surely something we need.

To make your live easier in the future I will submit a whitespace change
to NSButtonCell and NSMenuItemCell removing all the tab characters.

Cheers,
Fred

Christopher Armstrong wrote:
> Hi
> 
> I've been playing around with our theming API (GSTheme) with the intent
> of fleshing it out a bit further. In order to confirm the style of
> programmatic API I've been using, I have been trying to integrate
> Windows uxtheme with the API in order to demonstrate it that it is
> possible.
> 
> For those who are interested in what is happening, and are running
> GNUstep on Windows XP or Vista, please look at:
> 
> http://carmstrong.fastmail.com.au/gnustep-gui-themeing-20070429.diff
> http://carmstrong.fastmail.com.au/win32theme.tgz
> 
> The first is a patch that should be applied against the current
> gnustep-gui SVN (don't use your working copy as this patch is not by any
> means complete). It gives a (partial) API for theming menus and
> scrollbars, on top of the existing buttons themeing.
> 
> The second file is a bundle that compiles to a theme. It links against
> uxtheme so you will need at least Windows XP (I've only tested against
> Windows Vista however) and uses code that is private and specific to the
> win32/winlib backend.
> 
> I'm putting this up as a point of discussion. Comments and suggestions
> are welcome.
> 
> Regards
> Chris
> carmstrong at fastmail dot com dot au
> 
> 
> _______________________________________________
> Discuss-gnustep mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/discuss-gnustep
>