gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Wayland backend design


From: Ivan Vučica
Subject: Re: Wayland backend design
Date: Thu, 14 Jan 2016 15:49:11 +0000

First, thank you for your work -- I have spotted this email and I'll be looking at it closer by/during this weekend. I'll just make a few notes on how I would personally like to review incoming patches.

I think it would be worth reviewing this code. If you agree, I'd love a patch series applied on top of a particular Subversion commit (possibly published as a series of Git commits on top of a mirror created by Gregory). Each patch should tackle one self-contained task ("git add -i" is awesome). Alternatively, each Git branch should tackle one task, and could be collapsed into a single patch (i.e. Subversion commit).

I'd personally like to review patches as a Git repository published on in whatever manner you prefer. If the patches are sent as .patch files, I will be applying them on top of whatever is the latest Git commit in Gregory's mirror of -gui and -back. Once done, they would be submitted to Subversion.

These approaches would be useful for easy review -- possibly even via Gerrit. What do you think?



Additionally -- because reviewed code is easier to review when executed -- could you prepare setup instructions so I can more easily build and run this? My desktop is Ubuntu 14.04; my understanding is that I will need to run Weston under X11 (Nvidia drivers I use are proprietary blobs; I haven't tried setting up X-less Wayland thus far).

Have you filled copyright assignment forms with FSF? This would be necessary to import your code into GNUstep itself.

On Thu, Jan 14, 2016 at 3:33 PM Gregory Casamento <address@hidden> wrote:
Gna does, but you can only have one repo per project and it takes them forever to respond if you need to modify it. I don't recommend gna unless you're comfortable with that.

Actually if you create a repo on github, https://git.gnu.io or equivalent that would be perfect for the Weston part of the changes.

For back I would recommend creating a branch in our existing repo which would allow us to figure out how we can get it into the main line. A full fork is too much.

GC
On Thu, Jan 14, 2016 at 10:27 Sergio L. Pascual <address@hidden> wrote:
On Wed, 2016-01-13 at 20:18 -0500, Gregory Casamento wrote:
> I am indescribably excited about this.   It looks awesome.   Just a
> few little quirks!  Wayland is definitely the way forward.   Please
> consider putting this up on in the repo on gna.org as this is an
> awesome development.  

This project requires changes in both core/back and weston. For weston,
the easiest way for me would be forking it and keeping a separate git repo elsewhere (does gna.org offer git repos?).

What is the preferred way to publish the changes in core/back? Sending
patches to the mailing list? A separate branch? A full fork to be
merged in a future?

Sergio.

_______________________________________________
Gnustep-dev mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/gnustep-dev

reply via email to

[Prev in Thread] Current Thread [Next in Thread]