Re: Building patch for MSYS2/MINGW32

[Riccardo Mottola]

Hi there,

Richard Frith-Macdonald wrote:
> Yes, I was specifically looking for a define to tell us we are on windows, 
> rather than one telling us we are using MSYS.
> That's mostly because David and others have recently suggested the possibility 
> of building ObjC code using the microsoft compiler.
>
> I think most of the windows-specific code we have is not really msys/mingw 
> specific, so we should propbably be reserving the use of __MINGW... for places 
> where it makes a difference.

I did not investigate in the detail, will do perhaps this afternoon, 
however the latest changes broke my MINGW build:

I am on 32 bit, that is our "standard" mingw.

 Compiling file properties.m ...
In file included from .././GNUstepBase/GSConfig.h:327,
                 from ../../Headers/GNUstepBase/GSVersionMacros.h:219,
                 from ../../Headers/Foundation/NSObjCRuntime.h:38,
                 from ../../Headers/Foundation/NSObject.h:30,
                 from properties.m:1:
G:/GNUstep/mingw/include/winsock2.h:603: error: syntax error before 
"WSAIsBlocki
ng"
G:/GNUstep/mingw/include/winsock2.h:607: error: syntax error before '*' 
token
G:/GNUstep/mingw/include/winsock2.h:607: error: `BOOL' declared as 
function retu
rning a function
G:/GNUstep/mingw/include/winsock2.h:607: error: 'BOOL' redeclared as 
different k
ind of symbol
G:/GNUstep/mingw/include/winsock2.h:603: error: previous declaration of 
'BOOL' w
as here
G:/GNUstep/mingw/include/winsock2.h:958: error: field `fActive' declared 
as a fu
nction
G:/GNUstep/mingw/include/winsock2.h:966: error: field `fActive' declared 
as a fu
nction
G:/GNUstep/mingw/include/winsock2.h:1149: error: `WSACloseEvent' 
declared as fun
ction returning a function
G:/GNUstep/mingw/include/winsock2.h:1160: error: 
`WSAGetOverlappedResult' declar
ed as function returning a function
G:/GNUstep/mingw/include/winsock2.h:1161: error: `WSAGetQOSByName' 
declared as f
unction returning a function
G:/GNUstep/mingw/include/winsock2.h:1184: error: `WSAResetEvent' 
declared as fun
ction returning a function
G:/GNUstep/mingw/include/winsock2.h:1188: error: `WSASetEvent' declared 
as funct
ion returning a function
G:/GNUstep/mingw/include/winsock2.h:1200: error: `LPFN_WSACLOSEEVENT' 
declared a
s function returning a function
G:/GNUstep/mingw/include/winsock2.h:1211: error: 
`LPFN_WSAGETOVERLAPPEDRESULT' d
eclared as function returning a function
G:/GNUstep/mingw/include/winsock2.h:1212: error: `LPFN_WSAGETQOSBYNAME' 
declared
 as function returning a function
G:/GNUstep/mingw/include/winsock2.h:1235: error: `LPFN_WSARESETEVENT' 
declared a
s function returning a function
G:/GNUstep/mingw/include/winsock2.h:1239: error: `LPFN_WSASETEVENT' 
declared as
function returning a function
In file included from ../../Headers/GNUstepBase/GSObjCRuntime.h:58,
                 from ../../Headers/Foundation/NSObjCRuntime.h:213,
                 from ../../Headers/Foundation/NSObject.h:30,
                 from properties.m:1:
G:/GNUstep/GNUstep/System/Library/Headers/objc/objc.h:42: error: 
conflicting typ
es for 'BOOL'
G:/GNUstep/mingw/include/winsock2.h:607: error: previous declaration of 
'BOOL' w
as here
G:/GNUstep/GNUstep/System/Library/Headers/objc/objc.h:42: error: 
conflicting typ
es for 'BOOL'

I will investigate further.. I am looking at the change,s but it is not 
obvious to me what broke it.
I think it is wrong to change the winsock2.h header order and the 
comment itself is wrong.

I swapped the two headers in GSConfig.h and got much further, but stop 
in NSDateFormatter (perhaps this has to do with ICU changes?)


later,


Riccardo