Re: [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effects

[Eric S. Raymond]

Christian Gagneraud <address@hidden>:
> A simple way to fix the problem and make everyone happy would be to
> create a gpsd_maybe_hexdump() that contains this "printable" test
> and either returns gpsd_hexdump() or the untouched buffer.
> 
> Then the coders have the choice between a real hexdump
> (gpsd_hexdump) and a "clever" hexdump (gpsd_maybe_hexdump).

I reached the same conclusion last night, and just pushed the change.  
The "clever" version is called gpsd_packetdump().

I guess this means you can push your test changes.
-- 
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>