gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effects


From: chris
Subject: [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effects
Date: Tue, 5 Jun 2012 17:26:19 +0100

From: Christian Gagneraud <address@hidden>

Hi,

These 5 patches make modifications to some code that affects other components.
Scons check passed on each individual commit, so there shouldn't be any 
regression.

- The first patch makes gpsdecode honor the unscaled flag, and fix SConstruct
  so that the tests are not affected.
- The second one makes gpsd_hexdump() always dump in hexadecimal form (no more
  "maybe text, maybe hex" behaviour)
- The third one increase the maximum json value length (AIS can produce "very"
  long strings)
- The forth one adds a new talker ID: BS, which is used by some AIS
  basestation
- The last one adds a simple script that can be used to check for JSON
  validity

All these patches are needed for the new AIS testing strategy, which will come
in two flavours: regression and stress.
I used this new test script on a large amount of data, and fixed a myriad of
small bugs and typos.

Christian Gagneraud (5):
  gpsdecode: honor scale flag
  gpsd_hexdump: Always dump in hex mode
  json.h: Change JSON_VAL_MAX from 120 to 512
  Add BS talker ID (used by AIS base stations)
  Add script to test for JSON validity

 SConstruct            |    6 +++---
 gpsdecode.c           |    3 +++
 hex.c                 |   47 ++++++++++++++++++-----------------------------
 json.h                |    2 +-
 packet.c              |   18 ++++++++++++++++++
 packet_states.h       |    2 ++
 test_json_validity.py |   23 +++++++++++++++++++++++
 7 files changed, 68 insertions(+), 33 deletions(-)
 create mode 100755 test_json_validity.py

-- 
1.7.7




reply via email to

[Prev in Thread] Current Thread [Next in Thread]